CoreLockingHelper: handle new Node types when retrieving task info from executionQueue #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpalcolea
force-pushed
the
CoreLockingHelper/handle-new-nodes-inexecution-graph
branch
2 times, most recently
from
9b8fcf5 to
6a4b257
Compare
…om executionQueue
rpalcolea
force-pushed
the
CoreLockingHelper/handle-new-nodes-inexecution-graph
branch
from
6a4b257 to
308e513
Compare
rpalcolea
deleted the
CoreLockingHelper/handle-new-nodes-inexecution-graph
branch
|
heads up @OdysseusLives https://github.com/gradle/gradle/blob/master/subprojects/core/src/main/java/org/gradle/execution/plan/OrdinalNode.java was introduced for 7.4 and it is the last node in the Changed the logic to query for the last task node. I guess at some point would be nice if we could move to public APIs for this or eventually remove it 😅 |
|
Thanks for the heads-up! I see what you mean there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.