refactor: assorted cleanups of store #6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use consistent spelling for `io::Reslut` * repplace `e.into()` with more explicit `io::Error::from` * implement From rather than Into * reduce minore code duplication by delegating to existing functions * use Arc::clone to make it explicit flow around store's identity * use buffered writer when dumping store to a file * fix latent bug around comparing wide pointers rust-lang/rust#69757. I thing we should not be hit by that due to full LTO, but that was a scary one. * remove some extra clones when working with cache
matklad
requested review from
nikurt and
mm-near
and removed request for
nikurt
mina86
approved these changes
Apr 11, 2022
pompon0
pushed a commit
that referenced
this pull request
Apr 15, 2022
* use consistent spelling for `io::Reslut` * replace `e.into()` with more explicit `io::Error::from` * implement From rather than Into * reduce minor code duplication by delegating to existing functions * use Arc::clone to make it explicit flow around store's identity * use buffered writer when dumping store to a file * fix latent bug around comparing wide pointers rust-lang/rust#69757. I thing we should not be hit by that due to full LTO, but that was a scary one. * remove some extra clones when working with cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io::Reslute.into()with more explicitio::Error::fromI thing we should not be hit by that due to full LTO, but that was a scary one.