Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GithubCI: switch to MacOS 13 #300

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

webwarrior-ws
Copy link
Contributor

@webwarrior-ws webwarrior-ws commented Dec 5, 2024

  • Changed MacOS version used in CI to 13, as version 12 got
    deprecated [1] and causes the jobs to be cancelled.
  • Installed specific versions of Xamarin.iOS & Xamarin.Android
    (the same as on MacOS 12), because MacOS 13 doesn't come with
    Xamarin preinstalled, and build fails with error:
/Users/runner/work/geewallet/geewallet/src/GWallet.Frontend.XF.iOS/GWallet.Frontend.XF.iOS.fsproj(92,11): error MSB4226: The imported project "/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/xbuild/Xamarin/iOS/Xamarin.iOS.FSharp.targets" was not found. Also, tried to find "Xamarin/iOS/Xamarin.iOS.FSharp.targets" in the fallback search path(s) for $(MSBuildExtensionsPath) - "/Library/Frameworks/Mono.framework/External/xbuild/" . These search paths are defined in "/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/MSBuild.dll.config". Confirm that the path in the <Import> declaration is correct, and that the file exists on disk in one of the search paths.
  • Installed .NET6 in macOS--dotnet6-only and
    macOS--dotnet6-and-mono jobs, because default .NET version
    on MacOS 13 is 8.0.404.

One thing to note is that now macOS--mono-only and
macOS--dotnet6-only take more time (20-25 minutes) and
became the slowest jobs.

[1] actions/runner-images#10721

@webwarrior-ws webwarrior-ws changed the base branch from master to stable December 5, 2024 13:49
@knocte
Copy link
Member

knocte commented Dec 8, 2024

because with default versions the build fails with error.

Please specify what are those default versions and copy+paste the error in the commit msg.

One thing to note is that now macOS--mono-only and macOS--dotnet6-only take more time (20-25 minutes) and became the slowest jobs.

Please include this info in the commit msg.

@knocte
Copy link
Member

knocte commented Dec 9, 2024

@webwarrior-ws also please create another PR for fixing fsx

@webwarrior-ws
Copy link
Contributor Author

because with default versions the build fails with error.

Please specify what are those default versions and copy+paste the error in the commit msg.

One thing to note is that now macOS--mono-only and macOS--dotnet6-only take more time (20-25 minutes) and became the slowest jobs.

Please include this info in the commit msg.

Changed commit message. I don't know what versions are installed by default on MacOS 13.

@webwarrior-ws
Copy link
Contributor Author

@webwarrior-ws also please create another PR for fixing fsx

What do you mean?

@knocte
Copy link
Member

knocte commented Dec 9, 2024

What do you mean?

fsx repo has the same problem, CI failing

@knocte
Copy link
Member

knocte commented Dec 9, 2024

I don't know what versions are installed by default on MacOS 13.

Please find out.

@webwarrior-ws
Copy link
Contributor Author

I don't know what versions are installed by default on MacOS 13.

Please find out.

Looks like Xamarin is not pre-installed on MacOS 13. But the errors are the same if the versions are wrong (not the same as on MacOS 12).

@knocte
Copy link
Member

knocte commented Dec 9, 2024

Change MacOS version used in CI to 13, as version 12 got
deprecated [1] and causes the jobs to be cancelled.

Install specific versions of Xamarin.iOS and Xamarin.Android
(the same as on MacOS 12), because MacOS 13 doesn't come with
Xamarin preinstalled, and build fails with error:
<snip/>

Install .NET6 in `macOS--dotnet6-only` and
`macOS--dotnet6-and-mono` jobs, because default .NET version
on MacOS 13 is 8.0.404.

One thing to note is that now `macOS--mono-only` and
`macOS--dotnet6-only` take more time (20-25 minutes) and
became the slowest jobs.

You still don't realize how weird it looks that some paragraphs are things you do but the last paragraph is a note?
If you use the infinite it feels like an imperative in English. If it was used only once, it would be obvious that it is just the action taken in the commit message, but as soon as you employ this more than once, then it feels weird. If more than one thing is done in the commit messate, then separate them in bullet points! Paragraphs are for prose, especially when there arte more than one.

@knocte
Copy link
Member

knocte commented Dec 9, 2024

Why would you violate the norms of the English language by using lowercase to start a sentence?

@webwarrior-ws
Copy link
Contributor Author

Why would you violate the norms of the English language by using lowercase to start a sentence?

Because it's a bullet list

@knocte
Copy link
Member

knocte commented Dec 9, 2024

Since when a bullet element has to start with lowercase? it's sentences what you have in the bullet list, not just items like "apple, banana, orange..."

@webwarrior-ws
Copy link
Contributor Author

Updated commit message and PR description

- Changed MacOS version used in CI to 13, as version 12 got
deprecated [1] and causes the jobs to be cancelled.
- Installed specific versions of Xamarin.iOS & Xamarin.Android
(the same as on MacOS 12), because MacOS 13 doesn't come with
Xamarin preinstalled, and build fails with error:
```
/Users/runner/work/geewallet/geewallet/src/GWallet.Frontend.XF.iOS/GWallet.Frontend.XF.iOS.fsproj(92,11): error MSB4226: The imported project "/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/xbuild/Xamarin/iOS/Xamarin.iOS.FSharp.targets" was not found. Also, tried to find "Xamarin/iOS/Xamarin.iOS.FSharp.targets" in the fallback search path(s) for $(MSBuildExtensionsPath) - "/Library/Frameworks/Mono.framework/External/xbuild/" . These search paths are defined in "/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/MSBuild.dll.config". Confirm that the path in the <Import> declaration is correct, and that the file exists on disk in one of the search paths.
```
- Installed .NET6 in `macOS--dotnet6-only` and
`macOS--dotnet6-and-mono` jobs, because default .NET version
on MacOS 13 is 8.0.404.

One thing to note is that now `macOS--mono-only` and
`macOS--dotnet6-only` take more time (20-25 minutes) and
became the slowest jobs.

[1] actions/runner-images#10721
@knocte knocte merged commit 7a0ace3 into nblockchain:stable Dec 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants