Improve DetectUnpinnedDotnetToolInstallVersions function #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
force-pushed
the
master
branch
2 times, most recently
from
d1bd1c2 to
908c11d
Compare
|
Maybe we need to expand this PR to also cover unpinned npm packages (e.g. see https://github.com/nodeeffect/RunIntoMe/commit/349e153aeb579ddc83a8a72a19e71480f26eca04 ). |
tehraninasab
force-pushed
the
improveUnpinnedDotnetToolInstallVersions-squashed
branch
from
e6c723d to
ef3e8bb
Compare
Add test for DetectUnpinnedDotnetToolInstallVersions function.
Add failing test for detecting unpinned version in npm package installations.
tehraninasab
force-pushed
the
improveUnpinnedDotnetToolInstallVersions-squashed
branch
from
8d0c2ac to
283602c
Compare
Implement DetectUnpinnedNpmPackageInstallVersions function.
tehraninasab
force-pushed
the
improveUnpinnedDotnetToolInstallVersions-squashed
branch
from
222cd21 to
5545a54
Compare
Add another test for DetectUnpinnedNpmPackageInstallVersions.
tehraninasab
force-pushed
the
improveUnpinnedDotnetToolInstallVersions-squashed
branch
6 times, most recently
from
987d052 to
35616b9
Compare
It's done |
knocte
reviewed
Jul 6, 2023
| @@ -77,7 +77,7 @@ jobs: | |||
| sudo apt install --yes --no-install-recommends npm curl | |||
| # need to update nodejs because with ubuntu's default nodejs version we would get this error: | |||
| # error @jest/[email protected]: The engine "node" is incompatible with this module. Expected version "^14.15.0 || ^16.10.0 || >=18.0.0". Got "12.22.9" | |||
| sudo npm install --global n | |||
| sudo npm install --global n@9.1.0 | |||
There was a problem hiding this comment.
@realmarv can we use stable instead?
There was a problem hiding this comment.
you mean @latest?
There was a problem hiding this comment.
no, in fact if using @latest, this script should fail as well
There was a problem hiding this comment.
I think there is no @stable tag
tehraninasab
force-pushed
the
improveUnpinnedDotnetToolInstallVersions-squashed
branch
from
35616b9 to
61ed51e
Compare
Add unpinnedNpmPackageInstallVersions.fsx script and specify package versions in npm install commands in GitHubCI.
Add failing test for DetectUnpinnedNpmPackageInstallVersions function.
Fix DetectUnpinnedNpmPackageInstallVersions function.
Add failing test for DetectUnpinnedNpmPackageInstallVersions function.
Fix DetectUnpinnedNpmPackageInstallVersions function.
tehraninasab
force-pushed
the
improveUnpinnedDotnetToolInstallVersions-squashed
branch
from
1433c8e to
bd8be73
Compare
knocte
force-pushed
the
master
branch
2 times, most recently
from
c5fb9d5 to
18898b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test and clean the code.