WorkflowGuidelines: add exception parsing #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aarani CI is broken. I know the failure msg is misleading, but that is already fixed in master. So please rebase first and then you will get a more understandable message. |
knocte
reviewed
May 27, 2023
| @@ -78,6 +78,46 @@ | |||
|
|
|||
| let savedData = System.IO.File.ReadAllText saveFilePath.FullName | |||
| ``` | |||
| * Avoid applying logic based on exception's message: | |||
|
|
|||
| Exception messages (even in stable libraries/softwares) are subject to change, applying logic based on the `Message` or `StackTrace` can cause hard-to-debug problems when updating your dependencies or in case of .NET even your framework version. | |||
knocte
reviewed
May 27, 2023
| () | ||
| with | ||
| | :? PostgresException as ex when | ||
| isDuplicatePrimaryKeyError ex -> |
There was a problem hiding this comment.
@aarani wrong indentation length
|
Also let's rebase this PR please. Thanks |
knocte
force-pushed
the
master
branch
2 times, most recently
from
d1bd1c2 to
908c11d
Compare
knocte
force-pushed
the
master
branch
2 times, most recently
from
c5fb9d5 to
18898b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.