fix: UnicodeDecodeError #490
Conversation
Fixes utf-8 encoding
```
- hook id: nbqa-black
- exit code: 1
- files were modified by this hook
Traceback (most recent call last):
File "c:\users\cees closed\.cache\pre-commit\repo9j8ifsr9\py_env-python3\lib\site-packages\nbqa\__main__.py", line 579, in _run_on_one_root_dir
replace_source.main(
File "c:\users\cees closed\.cache\pre-commit\repo9j8ifsr9\py_env-python3\lib\site-packages\nbqa\replace_source.py", line 88, in main
notebook_json = json.loads(notebook.read_text())
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.1776.0_x64__qbz5n2kfra8p0\lib\pathlib.py", line 1236, in read_text
return f.read()
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.1776.0_x64__qbz5n2kfra8p0\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 1184027: character maps to <undefined>
```
fix: utf-8 encoding
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 731 731
=========================================
Hits 731 731
Continue to review full report at Codecov.
|
|
Thanks @sbrugman , both for your kind words (mind if we include them as a testimonial?) and for this fix |
|
@all-contributors add @sbrugman for bugs |
|
I've put up a pull request to add @sbrugman! 🎉 |
Not at all, feel free @MarcoGorelli |
|
Thanks for the quick merge |
|
cool, thanks! Have made a patch release (0.5.2) with this fix |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 731 731
=========================================
Hits 731 731 ☔ View full report in Codecov by Sentry. |
nbQA helps us to keep notebooks to the same standards as the rest of the code. If you're serious about your code standards, you should keep them consistent across both notebooks and python scripts. Great addition to the ecosystem, thanks!
Version nbQA 0.5.1 throws an UnicodeDecodeError exception on my Windows machine. The proposed changes in this PR resolve it for my configuration, however I could imagine it's desirable to configure/automatically detect the charset for more general usage.
Find the updated configuration of how we use nbQA in pandas-profiling here: ydataai/ydata-profiling#628