Fix numpy doctest local #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace np.float_ with np.float64. The minimum numpy version 1.16 has both as aliases, the newer version numpy>=2.0 don't support np.float_ anymore.
[NEP51](https://numpy.org/neps/nep-0051-scalar-representation.html#backward-compatibility) changes the representation of scalars. While the long term strategy should be a comparison with the new form of representation, the discussion in [issue 24470](numpy/numpy#24470) seems to suggest to use an intermediate step while both, numpy-1 and numpy-2 are supported.
instead of setting an environment-specific number representation within numpy, this commit sets the number representation per test case and with a suggestion on how to change it once numpy>=2.0 is the minimal requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR potentially improves the numpy>=2.0 compatibility
This problem came up in #175 and is an alternative solution to #176.