-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H01 interface #162
H01 interface #162
Conversation
Thanks for this PR. I left a few comments above. In particular the docstrings need a bit of work as they still contain references to the MICrONS dataset. Additionally I have two questions/suggestions:
None of the above are mission critical and I'm happy to take a stab myself later. As an aside: unfortunately, the tutorial tests are currently only run on |
Thank you for the comments.
|
Sorry, I haven't had the time to properly look through the PR yet. Will try to do that in the second half of next week! |
@schlegelp @jinhan, i just wanted to check in on this. @schlegelp did you have a chance to look at the updated code already? |
Thanks for the prod. I'm on it now. I'm planning a new release sometime this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I made a few comments about docstrings that now only exists in cave_utils
but not in the actual user-facing functions. Otherwise, I think this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks!
H01 interface based on the latest master branch
navis/interfaces/h01.py
docs/examples/3_interfaces/plot_04_interface_h01.py