Add send-system-notification callable workflow #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 66c9a98.
lorenyu
changed the title
coilysiren
approved these changes
Dec 13, 2024
|
|
||
| system_notifications_config = { | ||
| channels = { | ||
| "workflow-failures" = { |
There was a problem hiding this comment.
Suggested change
| "workflow-failures" = { | |
| workflow-failures = { |
I don't think either - or _ in variable names requires quotes?
| workflow_dispatch: | ||
| inputs: | ||
| channel: | ||
| description: "Name of channel to use. Must be defined in /infra/project-config" |
There was a problem hiding this comment.
Suggested change
| description: "Name of channel to use. Must be defined in /infra/project-config" | |
| description: "Name of channel to use. Must be defined in /infra/project-config/system-notifications.tf" |
There was a problem hiding this comment.
that was intentional since I was just referring to the module not the specific file in case we rename the file, but you're right this is probably clearer will change
|
|
||
| - name: Send Slack message | ||
| if: ${{ steps.get-channel-type.outputs.channel_type == 'slack' }} | ||
| uses: slackapi/[email protected] |
There was a problem hiding this comment.
I'm glad this exists! I wrote my version using curl, and it was hecka annoying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related to navapbc/template-infra#808
Changes
Context for reviewers
I plan on adding documentation in a future PR once I get this working end to end for a few workflows
Testing
Ran workflow manually: https://github.com/navapbc/platform-test/actions/runs/12324530980
Preview environment for app