Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect Issues During Import #139

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Feb 21, 2024

Closes: NaN

What's Changed

  • Renamed ValidationIssues to ImporterIssues.
  • Implemented collection of ImporterIssues throughout the import process.
  • Fixed broken choice fields importer.
  • Corrected conversion of FHRP protocol vrrpX to vrrp.
  • Fixed total issues summary.
  • Implemented fields.fallback field definition and importer.
  • Implemented Nautobot required fields detection.
  • Simplified setting importers and fields:
    • Now it's not neccessary to call field.set_nautobot_field(), called by field.set_importer().
    • Merged field.set_default_importer to field.set_importer.

Notes

Pull request is divided into separate commits for review.

@snaselj snaselj marked this pull request as ready for review February 21, 2024 10:57
@snaselj snaselj mentioned this pull request Feb 21, 2024
@snaselj snaselj marked this pull request as draft February 23, 2024 09:01
@snaselj snaselj force-pushed the u/snaselj-napps-252-summarize-warnings branch from 0a149b8 to dbd5e45 Compare February 23, 2024 11:51
@snaselj snaselj marked this pull request as ready for review February 23, 2024 12:13
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snaselj snaselj merged commit bfdf7a0 into develop Feb 26, 2024
14 checks passed
@snaselj snaselj deleted the u/snaselj-napps-252-summarize-warnings branch February 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants