Fix color field source flapping #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snaselj
requested review from
glennmatthews,
lampwins and
chadell
as code owners
chadell
reviewed
Feb 16, 2024
| @@ -70,6 +71,16 @@ class PreImportResult(Enum): | |||
| USE_RECORD = True | |||
|
|
|||
|
|
|||
| class SourceFieldSource(Enum): | |||
There was a problem hiding this comment.
I don't get the purpose of this class. what does it mean?
There was a problem hiding this comment.
"Source Field Source" doesn't resonate with me...
There was a problem hiding this comment.
Added description for individual enum entries
chadell
reviewed
Feb 16, 2024
| @@ -38,8 +38,7 @@ class FieldSummary(NamedTuple): | |||
| nautobot_can_import: Optional[bool] | |||
| importer: Optional[str] | |||
| definition: Union[str, bool, int, float, None] | |||
| from_data: Optional[bool] | |||
| is_custom: Optional[bool] | |||
| sources: List[str] | |||
There was a problem hiding this comment.
I may be missing somethign, but I don't see this attribute initialized, just used
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: NaN
What's Changed