Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summaries #129

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Summaries #129

merged 2 commits into from
Feb 9, 2024

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Feb 8, 2024 •
edited
Loading

Closes: NaN

What's Changed

  • Added JSON and text summaries to test fixtures for easy comparison.
  • Refactored summary related code to be independent on Django or Nautobot.
  • Added summaries serialization and deserialization.

@snaselj snaselj mentioned this pull request Feb 8, 2024
Merged
2 tasks
@snaselj snaselj marked this pull request as ready for review February 8, 2024 08:30
chadell
chadell approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snaselj snaselj merged commit 7cb0c2f into develop Feb 9, 2024
14 checks passed
@snaselj snaselj deleted the u/snaselj-napps-219-summary branch February 9, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell approved these changes

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews is a code owner

@lampwins lampwins Awaiting requested review from lampwins lampwins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaselj @chadell