Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie updated by NetworkToCode Cookie Drift Manager Tool #126

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

nautobot-bot
Copy link
Contributor

Template:

{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.1.0",
    "path": null
}

Cookie:

{
    "remote": "https://github.com/nautobot/nautobot-app-netbox-importer.git",
    "path": "/tmp/tmpd9rybffa/nautobot-app-netbox-importer",
    "repository_path": "/tmp/tmpd9rybffa/nautobot-app-netbox-importer",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@glennmatthews @jathanism @lampwins @chadell",
        "full_name": "Network to Code, LLC",
        "email": "[email protected]",
        "github_org": "nautobot",
        "app_name": "nautobot_netbox_importer",
        "verbose_name": "Nautobot NetBox Importer",
        "app_slug": "nautobot-netbox-importer",
        "project_slug": "nautobot-app-netbox-importer",
        "repo_url": "https://github.com/nautobot/nautobot-app-netbox-importer",
        "base_url": "netbox-importer",
        "min_nautobot_version": "2.0.6",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotNetboxImporter",
        "project_short_description": "Data importer from NetBox 2.10.x to Nautobot.",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/netbox-importer/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpd9rybffa",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.1.0"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "8049fdf6443472afd47288205d8614c89d7b2c72",
    "draft": true
}

CLI Arguments:

{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.1.0",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false,
    "draft": null
}

bakebot and others added 4 commits January 29, 2024 09:25
Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.1.0",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-app-netbox-importer.git",
    "path": "/tmp/tmpd9rybffa/nautobot-app-netbox-importer",
    "repository_path": "/tmp/tmpd9rybffa/nautobot-app-netbox-importer",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@glennmatthews @jathanism @lampwins @chadell",
        "full_name": "Network to Code, LLC",
        "email": "[email protected]",
        "github_org": "nautobot",
        "app_name": "nautobot_netbox_importer",
        "verbose_name": "Nautobot NetBox Importer",
        "app_slug": "nautobot-netbox-importer",
        "project_slug": "nautobot-app-netbox-importer",
        "repo_url": "https://github.com/nautobot/nautobot-app-netbox-importer",
        "base_url": "netbox-importer",
        "min_nautobot_version": "2.0.6",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotNetboxImporter",
        "project_short_description": "Data importer from NetBox 2.10.x to Nautobot.",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/netbox-importer/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpd9rybffa",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.1.0"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "8049fdf6443472afd47288205d8614c89d7b2c72",
    "draft": true
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.1.0",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false,
    "draft": null
}
```
@snaselj
Copy link
Contributor

snaselj commented Jan 31, 2024

This pull request has been cleaned up and is ready for review.

@snaselj snaselj marked this pull request as ready for review January 31, 2024 12:06
@@ -31,5 +31,5 @@
- [ ] Attached Screenshots, Payload Example
- [ ] Unit, Integration Tests
- [ ] Documentation Updates (when adding/changing features)
- [ ] Example Plugin Updates (when adding/changing features)
- [ ] Example App Updates (when adding/changing features)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in the app cookiecutter at all - this is specific to Nautobot core?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will fix this in the template, and push it with a new re-bake.


## Install Guide

!!! note
Plugins can be installed manually or using Python's `pip`. See the [Nautobot documentation](https://nautobot.readthedocs.io/en/latest/plugins/#install-the-package) for more details. The pip package name for this plugin is [`nautobot-netbox-importer`](https://pypi.org/project/nautobot-netbox-importer/).
Apps can be installed manually or using Python's `pip`. See the [nautobot documentation](https://nautobot.readthedocs.io/en/latest/plugins/#install-the-package) for more details. The pip package name for this app is [`nautobot-netbox-importer`](https://pypi.org/project/nautobot-netbox-importer/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity - how does one "manually" install an app?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in the next re-bake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity - how does one "manually" install an app?

Naturally, you download the package, unzip it, then copy over file by file into site-packages 🤓


## Install Guide

!!! note
Plugins can be installed manually or using Python's `pip`. See the [Nautobot documentation](https://nautobot.readthedocs.io/en/latest/plugins/#install-the-package) for more details. The pip package name for this plugin is [`nautobot-netbox-importer`](https://pypi.org/project/nautobot-netbox-importer/).
Apps can be installed manually or using Python's `pip`. See the [nautobot documentation](https://nautobot.readthedocs.io/en/latest/plugins/#install-the-package) for more details. The pip package name for this app is [`nautobot-netbox-importer`](https://pypi.org/project/nautobot-netbox-importer/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Apps can be installed manually or using Python's `pip`. See the [nautobot documentation](https://nautobot.readthedocs.io/en/latest/plugins/#install-the-package) for more details. The pip package name for this app is [`nautobot-netbox-importer`](https://pypi.org/project/nautobot-netbox-importer/).
Apps can be installed manually or using Python's `pip`. See the [Nautobot documentation](https://nautobot.readthedocs.io/en/latest/plugins/#install-the-package) for more details. The pip package name for this app is [`nautobot-netbox-importer`](https://pypi.org/project/nautobot-netbox-importer/).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in the next re-bake.

snaselj added a commit to nautobot/cookiecutter-nautobot-app that referenced this pull request Feb 14, 2024
@snaselj
Copy link
Contributor

snaselj commented Feb 14, 2024

@glennmatthews Changes to the template: nautobot/cookiecutter-nautobot-app#86

cmsirbu pushed a commit to nautobot/cookiecutter-nautobot-app that referenced this pull request Feb 14, 2024
@snaselj snaselj merged commit 411e226 into develop Feb 26, 2024
16 checks passed
@snaselj snaselj deleted the drift-manager/pr branch February 26, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants