Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of NetBox 2.10.5 JSON data #3

Closed
cs-1 opened this issue Mar 4, 2021 · 2 comments · Fixed by #6
Closed

Import of NetBox 2.10.5 JSON data #3

cs-1 opened this issue Mar 4, 2021 · 2 comments · Fixed by #6
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cs-1
Copy link

cs-1 commented Mar 4, 2021

Environment

  • Nautobot version: 1.0.0b1
  • nautobot-netbox-importer version: 1.0.0

Proposed Functionality

Allow import of NetBox 2.10.5 JSON data.

Use Case

Migration from NetBox 2.10.5.

Sorry for posting this as a feature request but I have no idea where to ask this question. We're currently on NetBox 2.10.5 but would like to Migrate to Nautobot. Is it possible to migrate from 2.10.5 with the current importer? Thanks!

@glennmatthews
Copy link
Contributor

Hi, thanks for posting! Currently the plugin only accepts a stated NetBox version of "2.10.3" or "2.10.4" out of an abundance of caution (as those are the versions that it was primarily developed/tested against).

However, after a quick look at the NetBox 2.10.5 release notes, I don't see any database changes that should cause an issue. I'll update the plugin to accept "2.10.5" as a valid option when I have time (although I would also welcome a pull request, if you're so inclined - it should be a simple pair of changes to https://github.com/nautobot/nautobot-plugin-netbox-importer/blob/develop/nautobot_netbox_importer/management/commands/import_netbox_json.py and https://github.com/nautobot/nautobot-plugin-netbox-importer/blob/develop/nautobot_netbox_importer/diffsync/adapters/__init__.py).

In the meantime, you have my permission to "lie" to the plugin by telling it that the export from your 2.10.5 instance is actually a "2.10.4" export - it should work just fine in that context. :-)

@cs-1
Copy link
Author

cs-1 commented Mar 4, 2021

Great, thanks for the quick reply, @glennmatthews. I'll give it a try.

@glennmatthews glennmatthews added enhancement New feature or request good first issue Good for newcomers labels Mar 4, 2021
@glennmatthews glennmatthews self-assigned this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants