Documentation and error handling/logging fixes #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kircheneer
commented
Dec 19, 2024
Kircheneer
commented
- Fixed a couple of typos in different places
- Improved error handling for content provided by git repositories
- Aligned logging level and writing to that of Nautobot core provided messages
Kircheneer
force-pushed
the
lk-fixes
branch
2 times, most recently
from
4bbd249 to
3edfb41
Compare
Kircheneer
requested review from
glennmatthews,
chadell,
susanhooks,
Dav-C,
jeffkala and
scetron
as code owners
|
Happy to provide two separate PRs if you want. |
scetron
approved these changes
Dec 19, 2024
| next(repo_data_dir.glob("*.yml")) | ||
| except StopIteration: | ||
| job_result.log( | ||
| "Command mapper repo folder found, but it doesn't contain any command mapper files." |
There was a problem hiding this comment.
should there be a comma between these two strings or is this something I am unaware of?
There was a problem hiding this comment.
Actually, not! Check this:
>>> print("Hello I am"
... "Leo, you are Stephen")
Hello I amLeo, you are Stephen
You did, however, bring to my attention that a space is missing, I have removed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.