Improve support for instance variables in Marshal.dump #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is way too repetitive, and should be refactored before we can extend it to other classes.
Convert the encoding string to binary encoding, so we can use the generic write method to store it.
This makes the code a bit more generic
Don't clutter the generic Object dump
And uncover an issue with restoring this. You win some, you loose some. Since the load specs depend on dump, it's probably better to keep the dump and disable the load for now. The old code was passing, but this was a coincidence.
seven1m
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only issues related to instance variables are related to non-ascii names, that is an issue outside of Marshal.
This includes some rudimentary support for Exception and Struct dumping, the basic versions work but they still have to be refined.