-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poetry plugin #46
Conversation
There's still an open question about how to handle passing of arguments to tasks. This doesn't work out of the box since tasks are registered as commands using cleo as a CLI library. I'm afraid that it may be necessary to refactor poethepoet to use Cleo throughout! Though this might still not help for passing arbitrary args to cmd tasks for instance. I haven't looked into this properly yet. |
Ooh this looks promising. So you have the option to make it a prefix now? Also, I'm a bit confused on the |
a56b3a3
to
6ce55c2
Compare
38c4d2b
to
4ab5d5a
Compare
Looking good! Haven't tested it on my machine yet. Looking from the code, I guess you got the plugin to invoke the |
@@ -0,0 +1,193 @@ | |||
# pylint: disable=import-error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this? I think this was to silence Pylint from the try
/except
hack I did before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this to stop pylint complaining about cleo not being a direct dependency :)
@ThatXliner I think it's almost ready to go. If you could test it out a bit then that would be helpful :) |
Also: - Add `poetry poe` command without a task - Pass the poetry venv to poe directly via the plugin - Mark graph executions as multistage (for optimized use of poetry venv)
- Support level 2 verbosity to align with poetry semantics - Support passing a full PoeConfig to an instance of PoeThePoet
- Add test-quick task that excludes slow tests
4ab5d5a
to
0bc39aa
Compare
Based off of #32 by @ThatXliner and refactored a bit.
"run "
or'x "
etc.