Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powerpreference default #725

Merged
merged 1 commit into from Apr 15, 2021
Merged

Powerpreference default #725

merged 1 commit into from Apr 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2021

Changes Powerpreference to use default

@mitchmindtree
Copy link
Member

Context for future readers: this PR solves an issue where some systems will panic! during swapchain creation as a result of not being able to find a GPU that matches the HighPerformance power preference requested when instantiating the adapter.

By changing the default PowerPreference to Default, we increase the chance that we can find a compatible graphics device on the system.

In the future, we should:

  1. Add a short tutorial to the nannou guide that shows how to specify the HighPerformance power preference and
  2. Query for HighPerformance-capable devices in the case that wgpu ever gets an API that supports doing so.

@mitchmindtree mitchmindtree merged commit c369e59 into nannou-org:master Apr 15, 2021
@mitchmindtree
Copy link
Member

Related bevyengine/bevy#402.

This was referenced Apr 15, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mitchmindtree