Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12 by not resolving static value of Symbol() #13

Merged
merged 2 commits into from
May 14, 2021

Conversation

ninevra
Copy link
Contributor

@ninevra ninevra commented Aug 27, 2020

See title.

Closes #12.

I don't think this is a breaking change, since the public API doesn't make specific claims about what will and won't return non-null from getStaticValue().

@mysticatea mysticatea merged commit 994ee18 into mysticatea:master May 14, 2021
fisker pushed a commit to fisker/eslint-utils that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading result from getStaticValue() on expressions that re-use Symbol()s
2 participants