Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule node/no-unpublished-import should not be enabled for private packages #77

Open
josokinas opened this issue Apr 9, 2017 · 8 comments
Open

Rule node/no-unpublished-import should not be enabled for private packages #77

josokinas opened this issue Apr 9, 2017 · 8 comments
Labels
enhancement

Comments

@josokinas
Copy link

josokinas commented Apr 9, 2017 •
edited
Loading

If package.json file has "private" set to true, it will restrict the package from being published to the registry. Therefor having node/no-unpublished-import rule enabled does not make sense.
@ClementParis016
Copy link

I agree, and the same observation applies to node/no-unpublished-require.
Happy to make a PR if this should be addressed ;)

@pranshu-07
Copy link

Is this still in discussion ?

@mysticatea
Copy link
Owner

At least, I'm using those rules for private packages as well.

@GreatWizard GreatWizard mentioned this issue Jul 18, 2019
Merged
kellyselden pushed a commit to CrowdStrike/faltest that referenced this issue Sep 12, 2019
chore: remove npmignore file
3e77f2f 
mysticatea/eslint-plugin-node#77
@kellyselden kellyselden mentioned this issue Sep 12, 2019
Open
kellyselden pushed a commit to CrowdStrike/faltest that referenced this issue Sep 12, 2019
chore: remove npmignore file
d05f15b 
mysticatea/eslint-plugin-node#77
kellyselden pushed a commit to CrowdStrike/faltest that referenced this issue Sep 21, 2019
chore: remove npmignore file
88645a6 
mysticatea/eslint-plugin-node#77
@backspace backspace mentioned this issue Oct 15, 2019
Merged
kellyselden pushed a commit to CrowdStrike/faltest that referenced this issue Oct 27, 2019
chore: remove npmignore file
3050ec7 
mysticatea/eslint-plugin-node#77
kellyselden pushed a commit to CrowdStrike/faltest that referenced this issue Oct 27, 2019
chore: remove npmignore file
bcd7507 
mysticatea/eslint-plugin-node#77
@latipun7 latipun7 mentioned this issue May 11, 2020
Closed
@edg2s
Copy link

edg2s commented May 24, 2020

Could be an option instead?

@edg2s edg2s mentioned this issue May 24, 2020
Merged
@constgen
Copy link

constgen commented Feb 8, 2021

It is so obvious to me that I can't wait when this will be done. @mysticatea can you show examples of mistakes that you want to prevent with this rule in a private package?

@uhrohraggy
Copy link

Can we merge this in yet? Has been 5 years since this was opened?

This was referenced Oct 18, 2022
Merged
Closed
@angelayanpan
Copy link

can this issue be closed now?

@electriquo electriquo mentioned this issue Jul 23, 2023
Open
2 tasks
@voxpelli
Copy link

It has been merged into the maintained for, eslint-plugin-n: eslint-community#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@voxpelli @edg2s @constgen @mysticatea @angelayanpan @uhrohraggy @ClementParis016 @pranshu-07 @sosukesuzuki @josokinas