Updated readable-stream to v2.2.6 #1677
Conversation
|
It might be useful to enable something like greenkeeper? |
|
I haven't upgraded it because it's a breaking change... You can see the CI is broken. |
|
I think it is a problem with npm during the install step. readable-stream works fine on node 0.8 with this config https://github.com/nodejs/readable-stream/blob/master/.travis.yml, I'll see if that works here as well, or if there is an easy fix on readable-stream side. Have you got any plans to remove support for 0.6 and 0.8? |
|
Hi @mcollina it's still a breaking change if it's going to require users to upgrade their npm version just like it would be if we required then to upgrade their Node.js version.
I didn't even want to support Node.js 0.6 but added it because of the barrage of Node.js 0.6 issues that coming in because there were OS distros that only had 0.6 in their package manager, and of course this being a low level driver modules, apparently it is very popular among those types of users. I plan to drop them when 3.0 comes out, but that just needs myself or others to work on the issues tagged with 3.0 milestone for some of the "big bugs" that are lying around. |
|
@dougwilson would you mind restarting the build, now |
|
Hi @mcollina thanks for the update! I restarted the Travis CI build but it still fails. |
mcollina
force-pushed
the
updated-stream
branch
from
3b85bfa to
c211e9a
Compare
|
@dougwilson travis is passing with |
|
Hm, I wonder what changed to increase the flakiness of that test. I fixed it on master, so am merging your PR :) ! I assume that even though this is a major version bump of readable-stream, it won't actually cause any backwards compatibility issues within how we are exposing the streams to users, right? |
|
It is fully backward-compatible. The difference is that readable-stream v1 is streams 2, while readable-stream v2 is streams 3. |
|
Awesome! I'm just trying to determine what I need to add to the change log and what to change in the README regarding this. |
|
@mcollina I'm reverting this because |
|
@dougwilson I'll get you a new version. I'm not sure how I can test that still works on .travis.yml |
|
Yea, if you're using a test framework that doesn't care about old version support, you can't test on old versions. Your testing framework is the largest limiter for the version you can test against. Being from Perl, it's just mind-boggling that tests frameworks in Node.js don't strive to support all possible versions, instead typically only supporting very recent versions, driving modules that use them to have no choice in the versions they can test on. |
|
version 1 of The problem is not really the test framework. The problem is npm itself. |
|
I thought you were referring to testing the current readable-stream against things like Node.js 0.8 on Travis CI. |
|
Doing some tests, looks like even through I pinned the specific version of readable-steam in this PR, the reason why mysql is no longer installable is because it depends on a range for string_decoder and that module also introduced a |
|
a new version of both is coming. |
|
@dougwilson it should be fixed, a new version of |
|
Sweet, the string_decoder update fixed the current master version right away :) |
|
|
As titled.