Session and Candidate interaction cleanup #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcarbone
requested review from
aaronhurt,
nathanejohnson,
spellgen and
rossor
dcarbone
force-pushed
the
bugfix/session-churn
branch
from
af34ec8 to
db8d199
Compare
- Eliminated a few race conditions made present in previous updates - Added "AutoRun" concept to both Session and Candidate - Candidate.WaitX() methods will now return an error if called on a candidate that is not actively in the running - Moved the old Candidate tests to the candidate package and updated them appropriately - Added some more logging at key parts of the session and candidate keepalive loops - Severely reducing the complexity of the Candidate keepalive loop - Session will now attempt to actively destroy the upstream session if the state goes out of whack (generally due to timeout) - Normal session "update" calls no longer block (may want to add unecessary complexity to this later...) - Session.Stop() now returns an error, which if not nil can probably be ignored most of the time
dcarbone
force-pushed
the
bugfix/session-churn
branch
from
db8d199 to
dd3fcf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few race conditions and just weird logic implemented after the last push, this pr aims to clean up the candidate <-> session interactivity such that it is less complicated and more resilient.