This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
feat: support identity hashes #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/identity-hash
branch
from
ba36bbc to
5ef8fdc
Compare
vmx
approved these changes
Apr 8, 2019
daviddias
reviewed
Apr 10, 2019
| name: 'identity' | ||
| }, | ||
| hex: '7465737420737472696e6720f09f918d', | ||
| size: 16 |
There was a problem hiding this comment.
Was this test fixture taken from a go-ipfs/go-multiaddr example/output?
There was a problem hiding this comment.
no, I just made one, should I fetch one from there?
> Buffer.from('7465737420737472696e6720f09f918d', 'hex').toString()
'test string 👍'
|
Looks good, timeout to get a reply from @daviddias is reached (feel free to open an new issue), hence merging. |
|
@daviddias @vmx can we get a release of this? It's in master but there hasn't been a release of it. ref #68 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has come up a few times recently: inline IPLD blocks encoded within identity CIDs and inline entries in IPLD data structures (e.g. a HAMT/Map) encoded with identity CIDs, rather than links to different entities. I think this is an appropriate change here? Basically just removing the falsey coercion of
0x0.I've also changed
'id'to'identity'to match the multicodec table. I doubt this is a breaking change because it's not currently possible to use'id'anyway.