feat: add dnsnaddr p2p #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
reviewed
Oct 15, 2020
src/index.js
Outdated
| @@ -71,7 +72,8 @@ const Reliable = or( | |||
| WebRTCStar, | |||
| WebRTCDirect, | |||
| TCP, | |||
| UTP | |||
| UTP, | |||
| DNSADDR | |||
There was a problem hiding this comment.
Was this added to Reliable to support the test addition? We may need to replace this with DNS to cover the rest of the formats.
There was a problem hiding this comment.
This was added to support dials using dnsaddr/p2p/{ID} which fails the mafmt test for P2P on dial. I will change to support all DNS to cover the remaining cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per libp2p/js-libp2p#772 we need to support dnsaddr with
/p2p