Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Unique function #203

Merged
merged 2 commits into from
Jul 3, 2023
Merged

add a Unique function #203

merged 2 commits into from
Jul 3, 2023

Conversation

marten-seemann
Copy link
Contributor

This is the function we optimized in libp2p/go-libp2p#2395. The plan is to remove this function from go-libp2p.

@marten-seemann marten-seemann requested a review from MarcoPolo June 29, 2023 19:30
multiaddr.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a Unique and a UniqueSorted. UniqueSorted being the version that works if the list is already sorted.

@marten-seemann
Copy link
Contributor Author

I think there should be a Unique and a UniqueSorted. UniqueSorted being the version that works if the list is already sorted.

Updated to Unique. We can add a UniqueSorted later, if the need arises.

@marten-seemann marten-seemann requested a review from sukunrt July 3, 2023 19:16
@marten-seemann marten-seemann changed the title add a Deduplicate function add a Unique function Jul 3, 2023
@sukunrt
Copy link
Member

sukunrt commented Jul 3, 2023

Unique is nice.

@marten-seemann marten-seemann merged commit 589abd3 into master Jul 3, 2023
@MarcoPolo MarcoPolo mentioned this pull request Jul 14, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants