Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Improve print support #7407

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

cherniavskii
Copy link
Member

Backport of #6273 to the master branch.
The scroll jump is annoying and the print preview doesn't work on localhost, which makes it harder to look into print export issues reported lately (#7400)

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! v5.x feature: Export cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch labels Jan 6, 2023
@mui-bot
Copy link

mui-bot commented Jan 6, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 463 804 523.1 603.1 146.57
Sort 100k rows ms 532.3 967.1 857.7 773.12 168.749
Select 100k rows ms 188.4 275.2 256.2 240.1 31.703
Deselect 100k rows ms 126.2 199.6 161.6 163.8 24.641

Generated by 🚫 dangerJS against ec29193

@cherniavskii cherniavskii marked this pull request as ready for review January 6, 2023 14:10
@cherniavskii cherniavskii merged commit 11448e9 into mui:master Jan 6, 2023
@cherniavskii cherniavskii deleted the fix-print-export-scroll branch January 6, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch component: data grid This is the name of the generic UI component, not the React module! feature: Export v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants