[docs-infra] Transpile .ts demo files #15345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15345--material-ui-x.netlify.app/ |
KenanYusuf
force-pushed
the
transpile-ts-demo-files
branch
from
f0034f6 to
589a978
Compare
KenanYusuf
commented
Nov 13, 2024
| @@ -79,7 +81,7 @@ const TranspileResult = { | |||
| }; | |||
|
|
|||
| async function transpileFile(tsxPath, program, ignoreCache = false) { | |||
| const jsPath = tsxPath.replace('.tsx', '.js'); | |||
| const jsPath = tsxPath.replace(/\.tsx?$/, '.js'); | |||
KenanYusuf
commented
Nov 13, 2024
| @@ -42,7 +42,7 @@ const babelConfig = { | |||
|
|
|||
| const workspaceRoot = path.join(__dirname, '../../'); | |||
|
|
|||
| async function getFiles(root) { | |||
| async function getFiles(root, excludeRoot = false) { | |||
There was a problem hiding this comment.
I don't think we want to transpile files at the root of docs/data, e.g. https://github.com/mui/mui-x/blob/master/docs/data/chartsApiPages.ts, so I have added an extra option to this function to exclude the root files.
alexfauquette
approved these changes
Nov 13, 2024
KenanYusuf
added
needs cherry-pick
|
@alexfauquette is there something in particular that needs testing with that package? If it's related to mui/material-ui#44150, we're on |
I missed this update. Then it's all good, I tried the docs preview and nested files work perfectly on charts demo 🚀👌 |
|
Cherry-pick PRs will be created targeting branches: v7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15059
formattedTSDemos.jsscript to transpile.tsfiles.jsequivalents of.tsfiles in existing demosRelated to mui/material-ui#44150