Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Set closeOnSelect prop default value to false on pickers containing time views #14397

Conversation

arthurbalduini
Copy link
Member

@arthurbalduini arthurbalduini commented Aug 30, 2024

Closes #9310

This PR introduces a breaking change because it changes the default value of the closeOnSelect prop, as mentioned here

@arthurbalduini arthurbalduini added the component: pickers This is the name of the generic UI component, not the React module! label Aug 30, 2024
@mui-bot
Copy link

mui-bot commented Aug 30, 2024

@arthurbalduini arthurbalduini force-pushed the refactor-time-picker-closing-behavior branch from 9cfb636 to d3f2f8c Compare September 3, 2024 15:15
@arthurbalduini arthurbalduini force-pushed the refactor-time-picker-closing-behavior branch from d3f2f8c to 7e6879b Compare September 3, 2024 17:56
@LukasTy LukasTy added the enhancement This is not a bug, nor a new feature label Sep 9, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of it! 👍

I think that given this change of behavior, we should update the logic for default actions to also include the extended logic for closeOnSelect and have ['cancel', 'accept'] actions by default.
This would allow to remove the extra logic for this in:

const actionBarActions: PickersActionBarAction[] = shouldRenderTimeInASingleColumn
? []
: ['accept'];

const actionBarActions: PickersActionBarAction[] = shouldRenderTimeInASingleColumn
? []
: ['accept'];

Regarding the change itself—I think that we could deliver it on a minor release given a good changelog entry description and gotchas that people can expect when updating (i.e. the need to change tests), but I'd love to hear input from @flaviendelangle and @joserodolfofreitas.
Maybe you vote for keeping this change for v8 to avoid any potential backlash? 🤔

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2024
@arthurbalduini arthurbalduini force-pushed the refactor-time-picker-closing-behavior branch from 83349bd to 9bf7489 Compare September 30, 2024 10:38
@arthurbalduini arthurbalduini added breaking change v8.x and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Oct 9, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 9, 2024
@mui mui deleted a comment from github-actions bot Oct 9, 2024
@mui mui deleted a comment from github-actions bot Oct 9, 2024
@arthurbalduini arthurbalduini force-pushed the refactor-time-picker-closing-behavior branch from 3280fb5 to f820ac6 Compare October 9, 2024 20:05
@arthurbalduini arthurbalduini force-pushed the refactor-time-picker-closing-behavior branch from f820ac6 to 243ba59 Compare October 9, 2024 20:08
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 9, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another round of ideas. 😉

@arthurbalduini arthurbalduini force-pushed the refactor-time-picker-closing-behavior branch from cf02861 to 26f9e34 Compare October 31, 2024 16:37
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 5, 2024
Copy link

github-actions bot commented Nov 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 12, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 19, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature PR: out-of-date The pull request has merge conflicts and can't be merged v8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] Improve and simplify the auto-closing strategy of pickers with a value selected in several steps
5 participants