[DataGridPremium] Render aggregation label when renderHeader is used
#10936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
bug 🐛
|
Deploy preview: https://deploy-preview-10936--material-ui-x.netlify.app/ |
cherniavskii
commented
Nov 8, 2023
| await page.waitForFunction(() => { | ||
| const images = Array.from(document.querySelectorAll('img')); | ||
| return images.every((img) => img.complete); | ||
| }); |
There was a problem hiding this comment.
This should work better now
There was a problem hiding this comment.
Nice, even simpler than #5473 (comment), relying on pulling.
romgrk
approved these changes
Nov 8, 2023
cherniavskii
changed the title
renderHeader is being usedrenderHeader is used
cherniavskii
added a commit
to cherniavskii/mui-x
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10817
Before: https://codesandbox.io/s/renderheader-mui-bug-forked-lv9xhc
After: https://codesandbox.io/s/renderheader-mui-bug-forked-pqkdfk