-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Fix keyboard navigation for actions cell with disabled buttons #10882
Conversation
… set this to the state
Deploy preview: https://deploy-preview-10882--material-ui-x.netlify.app/ |
Couldn't test this, the CSB build links don't work. Do you have a CSB we can test this in? |
Open question, if the focus is on the cell to the right and the user presses "left", should the focus be on the first action or would it make sense to focus the last? |
Good question: I did ask myself the same tbh. I can create an issue to handle that, since this seems out of scope for this PR. Agree @romgrk ? |
This fixes the keyboard navigation for the actions cell when the first (or all) button is disabled.
It does also introduce a new check for the
managesOwnFocus
and renames it tocanManageOwnFocus
Screen.Recording.2023-11-03.at.10.17.00.mov
Fixes #10696