Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] React 19 useRef cleanup #44704

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Dec 9, 2024

Following up on this point, now that we've bumped to React 19 we can rely on useRef's overloads when initializing with null (reference) or undefined (reference). We were already doing so with null in some places. This PR makes the change for undefined (added in React 19), and standardizes it for null.

@DiegoAndai DiegoAndai added the React 19 support PRs required to support React 19 label Dec 9, 2024
@DiegoAndai DiegoAndai self-assigned this Dec 9, 2024
@mui-bot
Copy link

mui-bot commented Dec 9, 2024

Netlify deploy preview

https://deploy-preview-44704--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e603174

@DiegoAndai DiegoAndai added typescript core Infrastructure work going on behind the scenes labels Dec 9, 2024
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@DiegoAndai DiegoAndai merged commit b3ab4cf into mui:master Dec 9, 2024
25 checks passed
@DiegoAndai DiegoAndai deleted the react-19-useref-cleanup branch December 9, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes React 19 support PRs required to support React 19 typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants