Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Ignore browserslist and remove tag latest #44589

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[core] Ignore browserslist and remove tag latest #44589

merged 1 commit into from
Nov 28, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Nov 28, 2024 •
edited by sai6855
Loading

@siriwatknp siriwatknp requested a review from a team November 28, 2024 09:34
@siriwatknp siriwatknp added the core Infrastructure work going on behind the scenes label Nov 28, 2024
@mui-bot
Copy link

mui-bot commented Nov 28, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44589--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0d50f61

@aarongarciah aarongarciah changed the title [core] ignore browserlist and remove tag latest [core] Ignore browserlist and remove tag latest Nov 28, 2024
@aarongarciah aarongarciah changed the title [core] Ignore browserlist and remove tag latest [core] Ignore browserslist and remove tag latest Nov 28, 2024
@aarongarciah
Copy link
Member

@siriwatknp may I ask you to provide some context?

@sai6855

This comment was marked as outdated.

Sign in to view
sai6855

This comment was marked as outdated.

Sign in to view

@sai6855
Copy link
Contributor

sai6855 commented Nov 28, 2024

@siriwatknp Is this PR related to #44583?

@siriwatknp
Copy link
Member Author

siriwatknp commented Nov 28, 2024 •
edited
Loading

@siriwatknp may I ask you to provide some context?

  1. I could not run pnpm release:build without BROWSERSLIST_IGNORE_OLD_DATA=true because in v5.x the browserlist is outdated but we want to keep it that way.
  2. The --tag latest overrides v6 stable channel when I release v5.16.8 which was a nightmare ([material-ui][docs] Incorrect material ui version in stackblitz demos #44583) and (When i am installing material ui on my next js 15 version it gives me error #44584).

@sai6855 sai6855 dismissed their stale review November 28, 2024 09:58

Incorrectly understood the issue pr is solving

@siriwatknp siriwatknp merged commit fbf9bc1 into mui:v5.x Nov 28, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongarciah aarongarciah aarongarciah approved these changes

@sai6855 sai6855 sai6855 left review comments

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siriwatknp @mui-bot @aarongarciah @sai6855