-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add dark mode example for Material UI + Pigment CSS #44480
Conversation
Netlify deploy previewhttps://deploy-preview-44480--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you share a screen shot of how this looks (if you already have it) ?
Added in the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one comment on the theme creation. The rest looks good to me.
Fixes #44384
Add mode switcher on the Material UI + Pigment CSS example project. It's a fully end to end functional solution, by using cookie to store the previous setting and local storage to sync between tabs (similar to what the CSSVarsProvider offers).
Here is a preview: https://material-ui-pigment-css-dark-mode-switch.vercel.app/