-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Button] Revert Button loading #44478
Conversation
This reverts commit 0aecafc.
Netlify deploy preview
IconButton: parsed: -4.33% 😍, gzip: -3.45% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
@zannager, since I don't work on Material UI, someone from the Core team might have better insights on the topic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
This reverts commit 232555b.
Is this about reverting #26666? It feels a bit like adding bloat, is Google translation + loading important enough? What if we were to give up on this? #27853 suggests that it's important to fix. But maybe we could leave this as a documentation note? We could ship this now, and wait to see it works. In the docs, we could suggest:
https://martijnhols.nl/gists/everything-about-google-translate-crashing-react is an interesting dive into this problem. |
This reverts commit 232555b.
This reverts commit 232555b.
To add
loading
to the Button, it's required to wrap the text with anotherspan
element to prevent Google translation crash so it's a breaking change.The work can be revisited in v7.
Revert #42987