Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test][Autocomplete] Make virtualize regression screenshots deterministic #44425

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

DiegoAndai
Copy link
Member

An oversight of #44382. The regression test was not deterministic, so the screenshots were unstable. This fixes it by creating the options deterministically while maintaining a similar behavior from the demo.

@DiegoAndai DiegoAndai added test component: autocomplete This is the name of the generic UI component, not the React module! labels Nov 15, 2024
@DiegoAndai DiegoAndai self-assigned this Nov 15, 2024
@mui-bot
Copy link

mui-bot commented Nov 15, 2024

Netlify deploy preview

https://deploy-preview-44425--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 47614c1

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I've missed while reviewing the fact that there is a random function while generating the regression test.

@DiegoAndai DiegoAndai merged commit f5f13b3 into mui:master Nov 18, 2024
19 checks passed
@DiegoAndai DiegoAndai deleted the autocomplete-regression-test branch November 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants