-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Replace 'Experimental APIs - Toolpad' with 'Toolpad (Beta)' #44388
Conversation
Netlify deploy previewBundle size report |
As far as I know, this was correct, this feature is currently being experimented with in Toolpad Core and it's a table stake feature for any toast component to be taken seriously: https://www.notion.so/mui-org/core-Snackbar-component-c5f2d92ea5b74f52a65a7ff28a3a5c26. For example, Radix Primitives gives an example of how to build it, and Shadcn UI has it built natively. I wanted to have this in Material UI forever: #18098. Can we revert this? cc @colmtuite @aarongarciah depending on how far we want to go with the toast, I guess it will either be a Base UI or MUI feature, depending on where we want to draw the line. |
I am getting the same error. |
Perhaps you can create a new PR that reverts this commit, we can merge that |
|
@bharatkashyap Permissions related. Most of the MUI org repositories prevent the creation of new branches on the repository. They have to be created on a fork. This restriction exists so that branches don't add noise, keeping this easy to use: Renovates adds a lot of noise, but it's only because we are slow in merging them, we use to merge them fast enough not to have more than 10 opens. |
Co-authored-by: Bharat Kashyap <[email protected]>
@oliviertassinari Base UI will release Toast in Q1, and then Material UI will wrap it for v8. |
@colmtuite Toast should be in Base UI, agree. Linked this to mui/base-ui#220. I was more thinking about: would Base UI supports the imperative API or only MUI? For example, Radix Primitives doesn't support it, proof: https://www.radix-ui.com/primitives/docs/components/toast#imperative-api, maybe it's for the best, unclear. |
One title was missed in #43796