Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Fix default props theme scoping #44340

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Nov 7, 2024

closes #44334

Tested locally using the CodeSandbox build, the change works as expected but not with CodeSandbox web (something is wrong from their side).

@siriwatknp siriwatknp requested a review from DiegoAndai November 7, 2024 08:11
@siriwatknp siriwatknp added regression A bug, but worse package: material-ui Specific to @mui/material v6.x labels Nov 7, 2024
@mui-bot
Copy link

mui-bot commented Nov 7, 2024

Netlify deploy preview

https://deploy-preview-44340--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against a4fdb6c

@siriwatknp siriwatknp self-assigned this Nov 7, 2024
@siriwatknp siriwatknp requested a review from DiegoAndai November 8, 2024 02:07
@siriwatknp siriwatknp merged commit eded485 into mui:master Nov 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material regression A bug, but worse v6.x
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[material-ui] defaultProps ignored when using theme scoping
3 participants