Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Enforce punctuation on descriptions #44292

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 1, 2024

I noticed this in: https://github.com/mui/toolpad/pull/4344/files#r1826369440.

I didn't look at how this can be replicated on the next docs-infra structure, but at least, in the meantime, we will make sure it's done right, less migration effort. I opened mui/toolpad#4351 and mui/mui-x#15229 to make it easier for those repositories to upgrade docs-infra with this PR in.

@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product labels Nov 1, 2024
@mui-bot
Copy link

mui-bot commented Nov 1, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9ba44d3

@bharatkashyap bharatkashyap changed the title [docs-infra] Enforce ponctuation on descriptions [docs-infra] Enforce punctuation on descriptions Nov 2, 2024
@oliviertassinari
Copy link
Member Author

Merging, this seems non-controversial. I have added point 22. in mui/base-ui#588 to keep some track of this, so all good 😁

@oliviertassinari oliviertassinari merged commit c1d82a3 into mui:master Nov 9, 2024
22 checks passed
@oliviertassinari oliviertassinari deleted the description-dot branch November 9, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants