[docs] Mark the Hidden component as deprecated in the sidenav #44068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice suggestion! |
|
@jimmycallin Can you update the branch with the latest master? somehow I could not checkout this branch locally. |
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
patch-1
branch
from
aa576ed to
1d53beb
Compare
Netlify deploy previewhttps://deploy-preview-44068--material-ui.netlify.app/ Bundle size report |
|
This made me realize that we never created an issue to keep track of the end of this component, never too late, #44073. |
aarongarciah
requested review from
aarongarciah
and removed request for
siriwatknp
aarongarciah
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Grid component had a nice deprecated label in the navigation drawer, while Hidden didn't despite being deprecated, so added it :)
Preview: https://deploy-preview-44068--material-ui.netlify.app/material-ui/react-hidden/