Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui][Snackbar] Improve reason type in demos #43077

Merged
merged 4 commits into from
Jul 28, 2024
Merged

[docs][material-ui][Snackbar] Improve reason type in demos #43077

merged 4 commits into from
Jul 28, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jul 26, 2024 •
edited
Loading

This PR applies SnackbarCloseReason type to reason argument.

@sai6855 sai6855 added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature labels Jul 26, 2024
@mui-bot
Copy link

mui-bot commented Jul 26, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43077--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c7726d4

@sai6855 sai6855 requested a review from ZeeshanTamboli July 26, 2024 13:15
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Snackbar] Improve reason type in demos [docs][material-ui][Snackbar] Improve reason type in demos Jul 28, 2024
@ZeeshanTamboli ZeeshanTamboli added the component: snackbar This is the name of the generic UI component, not the React module! label Jul 28, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge label Jul 28, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 3e206fb into mui:next Jul 28, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
@sai6855 @ZeeshanTamboli @web-flow
[docs][material-ui][Snackbar] Improve reason type in demos (#43077)
ca4acc0 
Co-authored-by: ZeeshanTamboli <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 28, 2024
Merged
@oliviertassinari
Copy link
Member

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: snackbar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sai6855 @mui-bot @oliviertassinari @ZeeshanTamboli