[material-ui][joy-ui] Add InitColorSchemeScript for Next.js App Router
#42829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: material-ui
siriwatknp
changed the title
InitColorSchemeScript for Next.js App Router (#42247)InitColorSchemeScript for Next.js App Router
Netlify deploy preview
@material-ui/core: parsed: +0.11% , gzip: +0.14% Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
reviewed
Jul 3, 2024
| @@ -121,23 +121,47 @@ If you try to render your UI based on the server, before mounting on the client, | |||
|
|
|||
| ### Avoiding screen flickering | |||
|
|
|||
| To [prevent the UI from flickering](/joy-ui/main-features/dark-mode-optimization/#the-problem-flickering-on-first-load), apply `getInitColorSchemeScript()` before the main application script－it varies across frameworks: | |||
| To [prevent the UI from flickering](/joy-ui/main-features/dark-mode-optimization/#the-problem-flickering-on-first-load), apply `<InitColorSchemeScript />` before the main application script－it varies across frameworks: | |||
There was a problem hiding this comment.
Suggested change
| To [prevent the UI from flickering](/joy-ui/main-features/dark-mode-optimization/#the-problem-flickering-on-first-load), apply `<InitColorSchemeScript />` before the main application script－it varies across frameworks: | |
| To [prevent the UI from flickering](/joy-ui/main-features/dark-mode-optimization/#the-problem-flickering-on-first-load), add the `<InitColorSchemeScript />` component before the `<CssVarsProvider />` component: |
Maybe rephrase, as it is no longer a script.
mnajdova
approved these changes
Jul 3, 2024
…/InitColorSchemeScript
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
Thanks @siriwatknp To double-check, is the deprecation notice intentional for the v5? |
This was referenced Jul 3, 2024
Yes, the deprecation should happen on v6. I will open another PR to remove the warning. |
1 task
This was referenced Jul 26, 2024
This was referenced Jul 27, 2024
This was referenced Aug 10, 2024
Open
This was referenced Aug 11, 2024
This was referenced Aug 12, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #42247 to unblock MUI X on mui/mui-x#13712