Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Revert lint for useThemeProps #42817

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[core] Revert lint for useThemeProps #42817

merged 2 commits into from
Jul 3, 2024

Conversation

siriwatknp
Copy link
Member

To unblock MUI X

@siriwatknp siriwatknp added the core Infrastructure work going on behind the scenes label Jul 2, 2024
@mui-bot
Copy link

mui-bot commented Jul 2, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42817--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f2747f1

flaviendelangle
flaviendelangle approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks for taking care of it!

mnajdova
mnajdova approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to create a PR on MUI X with referencing this commit?

@siriwatknp siriwatknp mentioned this pull request Jul 3, 2024
Closed
1 task
@siriwatknp
Copy link
Member Author

There is an error due to InitColorSchemeScript that's added in alpha.

I will open another PR to add it to v5.

@siriwatknp siriwatknp merged commit 48cac39 into mui:next Jul 3, 2024
19 of 20 checks passed
@siriwatknp siriwatknp mentioned this pull request Jul 12, 2024
Merged
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@siriwatknp @joserodolfofreitas
[core] Revert lint for useThemeProps (mui#42817)
6489b95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siriwatknp @mui-bot @flaviendelangle @mnajdova