-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Alert] Add ability to override slot props #42787
Merged
ZeeshanTamboli
merged 4 commits into
mui:next
from
alexey-kozlenkov:feat/alert-override-slot-props
Jun 30, 2024
Merged
[material-ui][Alert] Add ability to override slot props #42787
ZeeshanTamboli
merged 4 commits into
mui:next
from
alexey-kozlenkov:feat/alert-override-slot-props
Jun 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-42787--material-ui.netlify.app/ Bundle size report |
alexey-kozlenkov
changed the title
[material-ui][Alert] Add option to override slot props
[material-ui][Alert] Add ability to override slot props
Jun 29, 2024
ZeeshanTamboli
added
typescript
package: material-ui
Specific to @mui/material
component: alert
This is the name of the generic UI component, not the React module!
enhancement
This is not a bug, nor a new feature
labels
Jun 30, 2024
ZeeshanTamboli
added
the
needs cherry-pick
The PR should be cherry-picked to master after merge
label
Jun 30, 2024
ZeeshanTamboli
approved these changes
Jun 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexey-kozlenkov Thanks for working on it. Looks good. I added a TypeScript module augmentation test.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
Co-authored-by: ZeeshanTamboli <[email protected]>
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: alert
This is the name of the generic UI component, not the React module!
enhancement
This is not a bug, nor a new feature
needs cherry-pick
The PR should be cherry-picked to master after merge
package: material-ui
Specific to @mui/material
typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42601