[material-ui][private-theming] Fix issues reported by react compiler in mui-private-theming components
#42619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-42619--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
commented
Jun 11, 2024
| @@ -52,7 +52,8 @@ function ThemeProvider(props) { | |||
| } | |||
|
|
|||
| const theme = React.useMemo(() => { | |||
| const output = outerTheme === null ? localTheme : mergeOuterLocalTheme(outerTheme, localTheme); | |||
| const output = | |||
| outerTheme === null ? { ...localTheme } : mergeOuterLocalTheme(outerTheme, localTheme); | |||
There was a problem hiding this comment.
this change fixed
Mutating component props or hook arguments is not allowed. Consider using a local variable insteadeslint(react-compiler/react-compiler) issue here
sai6855
changed the title
mui-private-theming componentsmui-private-theming components
sai6855
changed the title
mui-private-theming componentsmui-private-theming components
66 tasks
|
@aarongarciah feel free to merge PR, I can't merge |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jun 12, 2024
…in `mui-private-theming` components (mui#42619)
siriwatknp
added a commit
to michaldudak/material-ui
that referenced
this pull request
Jun 17, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
…in `mui-private-theming` components (mui#42619)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42564