[docs] Fix dashboard template console error #42594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-42594--material-ui.netlify.app/ Bundle size report |
NMinhNguyen
reviewed
Jun 10, 2024
| <Grid container spacing={2} columns={12}> | ||
| {data.map((card, index) => ( | ||
| <Grid xs={6} sm={3} md={2} lg={2.25}> | ||
| <StatCard key={index} {...card} /> | ||
| <Grid key={index} xs={6} sm={3} md={2} lg={2.25}> |
There was a problem hiding this comment.
What do you think about this diff instead?
Suggested change
| <Grid key={index} xs={6} sm={3} md={2} lg={2.25}> | |
| <Grid key={card.title} xs={6} sm={3} md={2} lg={2.25}> |
There was a problem hiding this comment.
I could see the same title with different time ranges: https://deploy-preview-42594--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/. I don't think it matters here that it uses the array index. It will be more flexible for people.
There was a problem hiding this comment.
Ah okay, was just commenting based on data in this file.
6 tasks
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jun 12, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-42594--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/