Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Disable eslint-plugin-react-compiler for Base #42563

Merged

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jun 7, 2024

Part of #42548

Disabling the eslint-plugin-react-compiler rules in the mui-base folder because we don't want to invest time in fixing issues relative to Base UI because Base UI is moving to https://github.com/mui/base-ui in the future.

@aarongarciah aarongarciah added core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Jun 7, 2024
@aarongarciah aarongarciah requested a review from michaldudak June 7, 2024 12:02
@aarongarciah aarongarciah force-pushed the disable-eslint-react-compiler-base-ui branch from 84c5bac to 4d1f459 Compare June 7, 2024 12:04
@aarongarciah aarongarciah marked this pull request as ready for review June 7, 2024 12:04
@mui-bot
Copy link

mui-bot commented Jun 7, 2024

Netlify deploy preview

https://deploy-preview-42563--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4d1f459

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aarongarciah aarongarciah merged commit 9acbedb into mui:next Jun 7, 2024
19 checks passed
@aarongarciah aarongarciah deleted the disable-eslint-react-compiler-base-ui branch June 7, 2024 13:11
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants