[joy-ui][docs] Add Next.js App Router instructions on how to prevent flickering #42514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Afanasiev <[email protected]>
1 task
Netlify deploy previewBundle size report |
danilo-leal
added
docs
danilo-leal
reviewed
Jun 3, 2024
Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: Tim Afanasiev <[email protected]>
|
Is everything all right now? 😉 |
|
It is on my end! I'd want @siriwatknp to double-check the actual code snippet there, though, and then we can jump in to fix the CI checks! |
|
Hey @siriwatknp! Can you have a look? :) |
siriwatknp
approved these changes
Jun 9, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Next.js App Router instructions on how to prevent Flickering on first load.
Tested, works.
Preview:
https://deploy-preview-42514--material-ui.netlify.app/joy-ui/customization/dark-mode/#next-js-app-router
PS:
danilo-leal asked to change the target base to
next, and I didn't manage to do it in previous Pull Request - as expected x). Anyways, thanks Danilo!Previous Pull Request