[docs-infra] Add the Base UI logo with copy functionality #42446
Conversation
danilo-leal
added
design
danilo-leal
requested review from
colmtuite,
michaldudak,
zanivan and
alexfauquette
Netlify deploy previewhttps://deploy-preview-42446--material-ui.netlify.app/ Bundle size report |
|
I created a PR in the Base UI repo that includes the logo: mui/base-ui#444. Seems to be working well (at least locally; there are some issues on CI, though). |
|
@alexfauquette & @michaldudak can I ask y'all to give me a code-focused review? Let me know if there's anything that can be improved there 👍 |
| const handleCopy = (svgSnippet: string) => { | ||
| setCopied(true); | ||
| copy(svgSnippet).then(() => { | ||
| setTimeout(() => setCopied(false), 3500); |
There was a problem hiding this comment.
It's the delay for the snack bar notifying that the element got copied.
There was a problem hiding this comment.
Could it be a constant (or at least have a comment in code)?
Besides, snackbars can be configured to auto-hide, so we don't need a setTimeout here.
There was a problem hiding this comment.
Don't we need the setTimeout for the copy action, too, though? Like, similar to https://github.com/mui/material-ui/blob/next/docs/src/components/action/NpmCopyButton.tsx
Follow up to #42435 — This PR adds the Base UI logo to the navbars, together with the recently added copy SVG functionality. So, if you're visiting the Base UI docs, you should see the Base logo instead of the Material UI/MUI logo.
I generalized the recently created
MuiLogoMenucomponent, changing its name toLogoWithCopyMenu. Then, the specific SVG component, together with the SVG strings of each logo, is passed via the_app.jsfile.