Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Add docs for complementary stepper components #41900

Conversation

anle9650
Copy link
Contributor

@anle9650 anle9650 commented Apr 14, 2024

Part of #39952. Fixes #41454.

@zannager zannager added docs Improvements or additions to the documentation component: stepper This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Apr 15, 2024
@zannager zannager requested a review from DiegoAndai April 15, 2024 14:39
@DiegoAndai
Copy link
Member

@michaldudak, would you know the reason for this failure?

@michaldudak
Copy link
Member

No idea. It seems that only this PR is affected. We could try recreating the PR.

@anle9650
Copy link
Contributor Author

We could try recreating the PR.

I tried creating a new branch from upstream/next in #41993, but ran into the same problem 🤔

@michaldudak
Copy link
Member

Since this PR touches just the docs, it's safe to bypass the checks and merge it.

@DiegoAndai
Copy link
Member

Hey @anle9650, thanks for working on this. The changes look good to me, but I want to wait for @samuelsycamore's review in case there's anything to add or rephrase.

Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small style tweaks here, otherwise looking good. Thanks @anle9650 !

docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
docs/data/material/components/steppers/steppers.md Outdated Show resolved Hide resolved
anle9650 and others added 9 commits May 17, 2024 22:06
@anle9650
Copy link
Contributor Author

Thank you for the suggestions @samuelsycamore !

@anle9650 anle9650 requested a review from samuelsycamore May 26, 2024 17:07
@mui-bot
Copy link

mui-bot commented Jun 11, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8a4a2c2

@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge label Jun 11, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][docs] Add docs for complementary stepper components [docs][material-ui] Add docs for complementary stepper components Jun 11, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 0bddcac into mui:next Jun 11, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
…1900)

Signed-off-by: Andy Le <[email protected]>
Signed-off-by: Zeeshan Tamboli <[email protected]>
Co-authored-by: Diego Andai <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: ZeeshanTamboli <[email protected]>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jun 12, 2024
…i#41900)

Signed-off-by: Andy Le <[email protected]>
Signed-off-by: Zeeshan Tamboli <[email protected]>
Co-authored-by: Diego Andai <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: ZeeshanTamboli <[email protected]>
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
…i#41900)

Signed-off-by: Andy Le <[email protected]>
Signed-off-by: Zeeshan Tamboli <[email protected]>
Co-authored-by: Diego Andai <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Stepper] Missing docs on the StepperContext and StepConnector sub-components
7 participants