Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Fix landing page template's h1 size #41543

Merged
merged 4 commits into from
Mar 18, 2024
Merged

[material-ui][docs] Fix landing page template's h1 size #41543

merged 4 commits into from
Mar 18, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Mar 18, 2024 •
edited by danilo-leal
Loading

Added clamp() to the h1 element in the landing page template to fix the massive layout shift on mobile when switching themes.

https://deploy-preview-41543--material-ui.netlify.app/material-ui/getting-started/templates/landing-page/

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Mar 18, 2024
@zanivan zanivan self-assigned this Mar 18, 2024
@zanivan zanivan requested a review from danilo-leal March 18, 2024 12:49
@mui-bot
Copy link

mui-bot commented Mar 18, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41543--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e714f82

danilo-leal
danilo-leal approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad we fixed this — left a couple of small remarks. (Also, you can cut the component="h1" prop given the variant is the same as the tag we want this component to render as)

docs/data/material/getting-started/templates/landing-page/components/Hero.js Outdated Show resolved Hide resolved
docs/data/material/getting-started/templates/landing-page/components/Hero.js Outdated Show resolved Hide resolved
@zanivan zanivan merged commit e164e6b into mui:master Mar 18, 2024
19 checks passed
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Open
Open
@RTHariSankar RTHariSankar mentioned this pull request May 21, 2024
Open
@GitLukeW GitLukeW mentioned this pull request May 21, 2024
Open
This was referenced Jun 5, 2024
Open
Open
@FaroukAmr FaroukAmr mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
@Poseidon-G Poseidon-G mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Open
Open
@sufi0900 sufi0900 mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 6, 2024
Open
Open
@mattboddy47 mattboddy47 mentioned this pull request Jun 6, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Open
This was referenced Jul 16, 2024
Open
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees

@zanivan zanivan

Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanivan @mui-bot @danilo-leal